Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent single Columns blocks transforming into Columns. #43641

Merged

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 26, 2022

Fixes: #43490

What?

Disable the ability to transform single Columns blocks into Columns blocks.

Why?

Transforming a single Columns block into another Columns block creates an unintuitive user experience and really should not be offered as a transform option.

How?

The transform has been updated to exclude single Columns blocks. You can still transform multiple Columns blocks into a Columns block. See the screenshots for more details.

Testing Instructions

  1. Add a Columns block and note that Columns no longer appears in the block transform menu.
  2. Add another Columns block.
  3. Select both Columns blocks and confirm that you can transform both into a single Columns block as expected.

Screenshots or screencast

Before:
image

After:
columns-transform

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Block] Columns Affects the Columns Block labels Aug 26, 2022
@ndiego ndiego self-assigned this Aug 26, 2022
@ndiego ndiego requested a review from ajitbohra as a code owner August 26, 2022 16:01
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ntsekouras ntsekouras merged commit ffe6c62 into WordPress:trunk Aug 29, 2022
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 29, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider offering a visual indicator post block transform
3 participants